Skip to content

refactor(i2c): simplify constructor #2553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2024
+1 −14
Merged

refactor(i2c): simplify constructor #2553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions libraries/Wire/src/Wire.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,6 @@ static const uint8_t MASTER_ADDRESS = 0x01;

// Constructors ////////////////////////////////////////////////////////////////

TwoWire::TwoWire()
{
memset((void *)&_i2c, 0, sizeof(_i2c));
_i2c.sda = digitalPinToPinName(SDA);
_i2c.scl = digitalPinToPinName(SCL);

txBuffer = nullptr;
txBufferAllocated = 0;
rxBuffer = nullptr;
rxBufferAllocated = 0;
}

TwoWire::TwoWire(uint32_t sda, uint32_t scl)
{
memset((void *)&_i2c, 0, sizeof(_i2c));
Expand Down
3 changes: 1 addition & 2 deletions libraries/Wire/src/Wire.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,7 @@ class TwoWire : public Stream {
void recoverBus(void);

public:
TwoWire();
TwoWire(uint32_t sda, uint32_t scl);
TwoWire(uint32_t sda = SDA, uint32_t scl = SCL);
~TwoWire();
// setSCL/SDA have to be called before begin()
void setSCL(uint32_t scl)
Expand Down
Loading