Skip to content

Conversation

its-kronos
Copy link
Contributor

@its-kronos its-kronos commented Aug 29, 2025

Summary

This PR fixes/implements the following bugs/features

Explain the motivation for making this change. What existing problem does the pull request solve?

Since it's a custom board, it has slightly different configuration compared to the generic (16 MHZ crystal instead of 8 MHZ), which means the exported binary from arduino with generic board doesn't work to establish serial communication

Validation

  • Ensure CI build is passed.
  • Demonstrate the code is solid. [e.g. Provide a sketch]

Code formatting

  • Ensure AStyle check is passed thanks CI

Closing issues

Fixes #xxx

@its-kronos
Copy link
Contributor Author

If there is a way to have custom pin namings, please let me know, the guide for adding a board isn't really clear on this

@its-kronos
Copy link
Contributor Author

also, is there a way I can test the code generated by stm32cubemx before the board gets into the offical

@fpistm fpistm added the new variant Add support of new bard label Sep 1, 2025
@fpistm fpistm added this to the 2.11.1/2.12.0 milestone Sep 1, 2025
@fpistm
Copy link
Member

fpistm commented Sep 1, 2025

If there is a way to have custom pin namings, please let me know, the guide for adding a board isn't really clear on this

You can create alias in the variant_DATABOARD.h like this:

#define My_CUSTOM_NAME PYn

#define IO1              PA10
#define AIO10              PA5

also, is there a way I can test the code generated by stm32cubemx before the board gets into the offical

Before it gets merged?
Well if you used the git repo instead of the package you could test it with Arduino IDE.
https://github.com/stm32duino/Arduino_Core_STM32/wiki/Using-git-repository

@its-kronos its-kronos marked this pull request as draft September 1, 2025 11:15
@its-kronos its-kronos marked this pull request as ready for review September 12, 2025 23:01
@its-kronos its-kronos marked this pull request as draft September 12, 2025 23:03
@its-kronos
Copy link
Contributor Author

need to test with arduino ide using repo before making PR ready for review

@its-kronos
Copy link
Contributor Author

After following the instructions in the using git repo, and successfully cloning with my board in the variants folder, I do not see an option to select it in Arduino IDE

image image

@its-kronos its-kronos marked this pull request as ready for review September 13, 2025 02:45
@fpistm
Copy link
Member

fpistm commented Sep 15, 2025

Hi @its-kronos

After following the instructions in the using git repo, and successfully cloning with my board in the variants folder, I do not see an option to select it in Arduino IDE

I fetch your PR and see the "databoard" in the menu.
You could try to made a "Reload Board Data" in the tools menu.
If it does not work after a restart, you could try to delete cache:
arduino/arduino-ide#1030 (comment)

@its-kronos its-kronos marked this pull request as draft September 15, 2025 20:39
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Maybe the name "DataBoard" is too generic and can be confusing?
Is it the final name?

@github-project-automation github-project-automation bot moved this from In progress to Reviewer approved in STM32 core based on ST HAL Sep 16, 2025
@fpistm
Copy link
Member

fpistm commented Sep 16, 2025

As you can see it is well defined and compiled by the CI:

image

@fpistm fpistm marked this pull request as ready for review September 16, 2025 08:24
@fpistm fpistm merged commit f1432b0 into stm32duino:main Sep 23, 2025
24 checks passed
@github-project-automation github-project-automation bot moved this from Reviewer approved to Done in STM32 core based on ST HAL Sep 23, 2025
@its-kronos
Copy link
Contributor Author

Thank you so much!

I honestly couldn't believe that this works, after so much time and I can't thank you enough!

image

Again, thank you

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new variant Add support of new bard

Projects

Development

Successfully merging this pull request may close these issues.

2 participants