Skip to content

Conversation

rweng
Copy link

@rweng rweng commented Mar 14, 2014

Just a suggestion, but since I needed it anyway I made a pull-request out of it:

Let's give the option to enable and disable platform/database specific tests. Why? For me, it's just that I have a different connection string for postgres. We could make it possible to pass it in, however, someone else might not have postgresql installed. As long as the platform-specific tests are run on travis before merge, I think it's more intuitive (for new developers) if the tests pass right away and no extra setup is required.

Let me know what you think.

@stmichael
Copy link
Owner

Such a mechanism is already provided with the rake tasks. Executing rake spec will only run unit, integration and acceptance tests. This will give you already the desired effect. When I work on data-import I always use the rake tasks to run a test suite and don't run rspec directly. Take a look at tasks/spec.rake for more information about the tasks.

But thanks to you, I found out that db specific tests haven't been run on travis until now. That's very naughty of me 😢

@stmichael
Copy link
Owner

The travis issue has been fixed on the current master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants