feat: add screenshare audio with muting capabilities#1055
Open
Dadadah wants to merge 1 commit intostoatchat:mainfrom
Open
feat: add screenshare audio with muting capabilities#1055Dadadah wants to merge 1 commit intostoatchat:mainfrom
Dadadah wants to merge 1 commit intostoatchat:mainfrom
Conversation
This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
Contributor
|
I'm 50/50 on if stream/user volume should persist through refreshes, but I do recall one of the other maintainers saying that feature should be added before. No clue if there's any consensus on that, though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds audio to the screenshare functionality of Stoat. It also adds the ability to mute and change volume of streams.
The stream volume data is stored in the voice state. This was an opinionated decision as I do not think that stream volume should persist through refreshes. It is easy to change it to use the stored settings states instead if the stream volume should remain through refreshes.
This PR does enable sound by default, and sound will always be shared until a settings UI is made for screensharing.