fix: Links in spoilers & multi-line spoilers#1056
Open
Pecacheu wants to merge 2 commits intostoatchat:mainfrom
Open
fix: Links in spoilers & multi-line spoilers#1056Pecacheu wants to merge 2 commits intostoatchat:mainfrom
Pecacheu wants to merge 2 commits intostoatchat:mainfrom
Conversation
Signed-off-by: Pecacheu <3608878+Pecacheu@users.noreply.github.com>
…ering text Signed-off-by: Pecacheu <3608878+Pecacheu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #790, as well as a related bug where links just straight up break if a spoiler ends with one, because
||is considered part of the link, and fixes multi-line spoilers too, which would render correctly in the text editor but then break upon being sent.Lastly, I changed the colors to some more sensible choices since they are extremely difficult to see. I went with
color-inverse-on-surfaceandon-secondary-fixed-variant, but welcome to feedback on those choices. That can be moved to it's own PR if requested.Old:
New:
