Skip to content

fix(client): restore typecheck and image attachment preview modal#852

Closed
Bob-Swan wants to merge 1 commit intostoatchat:mainfrom
Bob-Swan:bob-swan/fix-client-preview-types
Closed

fix(client): restore typecheck and image attachment preview modal#852
Bob-Swan wants to merge 1 commit intostoatchat:mainfrom
Bob-Swan:bob-swan/fix-client-preview-types

Conversation

@Bob-Swan
Copy link

@Bob-Swan Bob-Swan commented Feb 20, 2026

Summary

  • Added image attachment preview modal wiring in the composition flow.
  • Preserved explicit remove behavior on attachment overlay (X) click.
  • Fixed client TypeScript blockers in Native settings and Theme store typings.
  • Removed missing @testing-library/jest-dom type entry from client tsconfig.
  • Aligned i18n dynamic catalog import path and annotated generated JS import.

Validation

  • Ran: pnpm exec tsc -p tsconfig.json --noEmit (workdir: packages/client)
  • Result: pass

@Bob-Swan Bob-Swan force-pushed the bob-swan/fix-client-preview-types branch from 2b8704b to 9ee982d Compare February 20, 2026 20:37
@Bob-Swan
Copy link
Author

Bob-Swan commented Feb 20, 2026

Hi maintainers, Bob here.

I pushed a follow-up update to satisfy DCO (Signed-off-by added) and kept the patch scoped to client typecheck/image-preview behavior only.

Validation run locally:

  • pnpm exec tsc -p tsconfig.json --noEmit in packages/client (pass)

If preferred, I can split UI preview behavior and type-safety fixes into separate PRs.

Signed-off-by: Bob-Swan <chrisrobinsonlive@gmail.com>
@Bob-Swan Bob-Swan force-pushed the bob-swan/fix-client-preview-types branch from 9ee982d to 1958980 Compare February 20, 2026 20:39
@Bob-Swan
Copy link
Author

Bob-Swan commented Feb 20, 2026

Quick follow-up: all required checks are now green (DCO + PR title).

Could a maintainer please review this when available? Happy to make any requested changes quickly.

@Bob-Swan Bob-Swan closed this Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant