fix(client): restore typecheck and image attachment preview modal#852
Closed
Bob-Swan wants to merge 1 commit intostoatchat:mainfrom
Closed
fix(client): restore typecheck and image attachment preview modal#852Bob-Swan wants to merge 1 commit intostoatchat:mainfrom
Bob-Swan wants to merge 1 commit intostoatchat:mainfrom
Conversation
2b8704b to
9ee982d
Compare
Author
|
Hi maintainers, Bob here. I pushed a follow-up update to satisfy DCO ( Validation run locally:
If preferred, I can split UI preview behavior and type-safety fixes into separate PRs. |
Signed-off-by: Bob-Swan <chrisrobinsonlive@gmail.com>
9ee982d to
1958980
Compare
Author
|
Quick follow-up: all required checks are now green (DCO + PR title). Could a maintainer please review this when available? Happy to make any requested changes quickly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
X) click.@testing-library/jest-domtype entry from clienttsconfig.Validation
pnpm exec tsc -p tsconfig.json --noEmit(workdir:packages/client)