Update configuration.rst #505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Please also add them in the corresponding XML code block to keep code snippets in sync. |
Contributor
Author
|
Hello. You are exactly right. I updated xml example |
Contributor
Author
|
Hello. Is it okey? |
stof
requested changes
May 16, 2025
docs/configuration.rst
Outdated
| sortable="false" | ||
| softdeleteable="false" | ||
| uploadable="false" | ||
| reference_integrity="false" |
Owner
There was a problem hiding this comment.
XML attributes should use a dash instead of an underscore, to follow the usual XML convention (symfony/config is handling that normalization automatically).
As we don't have an XSD in this bundle, both _ and - will work, but the expected one (the one we would define in XSD if we were adding it) is the -.
docs/configuration.rst
Outdated
| id="default" | ||
| tree="true" | ||
| timestampable="false" | ||
| timestampable="false" <!-- not needed: listeners are not enabled by default --> |
Owner
There was a problem hiding this comment.
this is not valid XML. You cannot put a comment in the middle of attributes.
Contributor
Author
There was a problem hiding this comment.
Ok. I want to show extra info. I removed it
Add all extension names in config. It is more convenient for choose which you want enable. I miss this point and spent couple hours for configuring translations.
Contributor
Author
|
Nice weekend. I fixed PR. It`s ready to merge |
stof
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add all extension names in config. It is more convenient for choose which you want enable. I miss this point and spent couple hours for configuring translations.