fix schedule update progress intermitent failure

[birsanv]

Issue : the reconciler updates Velero Schedules then returns with a requeue. The test updates the spec again immediately and expects all 5 Schedules to reflect the new cron within 20s. Under envtest with controller cache sync and background work, reconcile can lag; the function returns an error for any partial progress which keeps Eventually in “error” state until it times out.
Fix: changed the test to stop failing on partial progress. It now keeps polling until all 5 Velero Schedules reflect the new cron, without emitting an error per tick.

The error:
[38;5;243m------------------------------[0m
[38;5;9m• [FAILED] [28.478 seconds][0m
[0mBackupSchedule controller [38;5;243mbasic backup schedule functionality [0mwhen testing schedule spec updates [38;5;9m[1m[It] should update velero schedules when BackupSchedule spec is changed[0m
[38;5;243m/go/src/github.com/stolostron/cluster-backup-operator/controllers/schedule_controller_test.go:1073[0m

[38;5;243mTimeline >>[0m
[1mSTEP:[0m creating backup schedule and waiting for all velero schedules [38;5;243m@ 08/19/25 14:34:29.828[0m
[1mSTEP:[0m verifying initial velero schedule configuration [38;5;243m@ 08/19/25 14:34:30.083[0m
[1mSTEP:[0m updating backup schedule spec with new cron and TTL values [38;5;243m@ 08/19/25 14:34:30.083[0m
[1mSTEP:[0m verifying backup schedule spec was updated [38;5;243m@ 08/19/25 14:34:30.088[0m
[1mSTEP:[0m waiting for controller to detect spec changes and update velero schedules [38;5;243m@ 08/19/25 14:34:30.089[0m
[1mSTEP:[0m verifying all velero schedules have new configuration [38;5;243m@ 08/19/25 14:34:32.204[0m
[1mSTEP:[0m verifying backup schedule status reflects successful update [38;5;243m@ 08/19/25 14:34:32.205[0m
[1mSTEP:[0m testing cron schedule update without TTL change [38;5;243m@ 08/19/25 14:34:32.207[0m
[1mSTEP:[0m waiting for controller to propagate cron schedule changes to all velero schedules [38;5;243m@ 08/19/25 14:34:32.212[0m
[38;5;9m[FAILED][0m in [It] - /go/src/github.com/stolostron/cluster-backup-operator/controllers/schedule_controller_test.go:1287 [38;5;243m@ 08/19/25 14:34:58.285[0m
[38;5;243m<< Timeline[0m

[38;5;9m[FAILED] Timed out after 20.001s.
All Velero schedules should be updated
The function passed to Eventually returned the following error:
<*errors.errorString | 0xc00051f540>:
schedule update progress: 0/5 updated
{
s: "schedule update progress: 0/5 updated",
}[0m

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[birsanv]

/retest

[sahare]

lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: birsanv, sahare

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [birsanv,sahare]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment