Skip to content

TLS profile consistency#1560

Open
sahare wants to merge 2 commits intostolostron:mainfrom
sahare:tls-profile-consistency
Open

TLS profile consistency#1560
sahare wants to merge 2 commits intostolostron:mainfrom
sahare:tls-profile-consistency

Conversation

@sahare
Copy link
Collaborator

@sahare sahare commented Feb 18, 2026

Implement TLS Profile Consistency for cluster-backup-operator
https://issues.redhat.com/browse/ACM-30169

What this PR does

  • Dynamically fetches TLS profile from APIServer.Spec.TLSSecurityProfile and applies it to the webhook server
  • Disables HTTP/2 by default to mitigate CVE-2023-44487 (Rapid Reset Attack)
  • Adds SecurityProfileWatcher controller to detect TLS profile changes and trigger pod restart
  • Falls back to Intermediate profile if APIServer config is unavailable

Changes

  • pkg/tlsconfig/tlsconfig.go - New package for TLS configuration logic
  • pkg/tlsconfig/tlsconfig_test.go - Unit tests (78.3% coverage)
  • main.go - TLS profile integration and watcher setup
  • go.mod / go.sum - Added controller-runtime-common and updated library-go
  • Dockerfile - Added COPY pkg/ pkg/
  • Dockerfile.rhtap - Added COPY pkg/ pkg/
  • Makefile - Extended test target to include ./pkg/...

Testing

make test passes (controllers: 94.2%, pkg/tlsconfig: 78.3% coverage)
Verified on cluster: TLS profile applied correctly, watcher triggers restart on profile change

Signed-off-by: sahare <sahare@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 18, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sahare

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments