🤖 Sync from open-cluster-management-io/config-policy-controller: #388 #1512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
/retest |
ref: https://issues.redhat.com/browse/ACM-22932 No logic changed here. Refactor before adding a new dry run cli flag Signed-off-by: Janelle Law <[email protected]> (cherry picked from commit f9ab0929b618099ae08a0b43bf4c80bc97cc0d25)
ref: https://issues.redhat.com/browse/ACM-22932 Instead of providing input yaml files to the dryrun command args, set the --from-cluster flag to read cluster resources via default kubeconfig. As before, the policies are patched with remediationAction: Inform, preventing modifications to the cluster. Signed-off-by: Janelle Law <[email protected]> (cherry picked from commit 3886abc3524cabb2106f4da64958d7c75099121b)
ref: https://issues.redhat.com/browse/ACM-22932 Tests the dryrun CLI can read resources from a cluster with --from-cluster flag. Reuses the dryrun unit test cases, applies the resources to the test kind cluster, then runs the e2e tests. Sometimes the policy diff from the cluster returns extra context lines surrounding the relevant +/- changes. When this diff does not match the expected output.txt from the unit tests, the e2e test will compare the output with the output_from_cluster.txt file. Assisted by Cursor. Signed-off-by: Janelle Law <[email protected]> (cherry picked from commit c823ed6b6f1c2300708f954f77cafb17606bc183)
Tests dryrun scenarios in any order. Refactored namespace creation/deletion before and after each test Entry in DescribeTable. Eventually() will retry the dryrun command to wait for any duplicate resources pending deletion from previous test cases. ref: https://issues.redhat.com/browse/ACM-22932 Assisted by Cursor. Signed-off-by: Janelle Law <[email protected]> (cherry picked from commit d2c11fc2add9006ac871b0547d5591f94d8076ad)
dhaiducek
force-pushed
the
magic-mirror-main-1759933459406
branch
from
c511aaa to
f5b1943
Compare
dhaiducek
approved these changes
Oct 17, 2025
Assisted-by: Claude code Signed-off-by: Dale Haiducek <[email protected]>
Signed-off-by: Dale Haiducek <[email protected]>
|
jan-law
approved these changes
Oct 20, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, jan-law, magic-mirror-bot[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncing the following PRs:
Closes #1513
Resolves blocking CI failures in: