Skip to content

Conversation

@chrisahl
Copy link
Contributor

@chrisahl chrisahl commented Oct 28, 2021

Description of the change:
Add the ability to deploy on OpenShift where ACM should be limited to infra nodes

Motivation for the change:
Need to be able to deploy ACM on and environment that has infra nodes.

@openshift-ci
Copy link

openshift-ci bot commented Oct 28, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chrisahl
To complete the pull request process, please assign kyl-bempah after the PR has been reviewed.
You can assign the PR to them by writing /assign @kyl-bempah in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chrisahl chrisahl marked this pull request as ready for review October 28, 2021 21:32
@chrisahl
Copy link
Contributor Author

chrisahl commented Oct 28, 2021

/assign @gurnben

While I was not successful getting deploy to install ACM, this change helped me get past the first pod hanging in a Pending state. But then got stuck with

image

This is a generic statement and should not cause issues on regular 3 master 3 worker setups

@openshift-ci
Copy link

openshift-ci bot commented Dec 18, 2021

@chrisahl: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants