Update relative paths in start.sh script for MCE installs #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rhmdnd The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This installation script must have been shuffled around from the root of the repository since it contained relative paths to files and directories available from the repository root. Following the directions in the multiclusterengine/ directory results in a failed deploy because the script assumes those relative paths. This commit updates the script so that it installs cleanly by updating the relative paths. Closes stolostron#242
rhmdnd
force-pushed
the
fix-relative-paths-in-mce-install-script
branch
from
868701f to
2aac894
Compare
Contributor
|
@rhmdnd: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This installation script must have been shuffled around from the root of
the repository since it contained relative paths to files and
directories available from the repository root. Following the directions
in the multiclusterengine/ directory results in a failed deploy because
the script assumes those relative paths.
This commit updates the script so that it installs cleanly by updating
the relative paths.
Closes #242