Skip to content

Conversation

@kurwang
Copy link
Contributor

@kurwang kurwang commented Jan 28, 2026

Description

Proposing better roles for fine-grained rbac roles for ACM 2.16 GA

Related Issue

https://issues.redhat.com/browse/ACM-26301

Changes Made

Renaming existing fine-grained rbac roles in ACM 2.15 to better proposed ones for permissions related to CNV Fleet Virtualization UI and Live Migration of VMs

google doc outlining changes
https://docs.google.com/document/d/17usPdqxa3fdEgkP1NL7v7CkwPrORA38HO_7uyD4N2D8/edit?usp=sharing

Screenshots (if applicable)

Add screenshots or GIFs that demonstrate the changes visually, if relevant.

Checklist

  • I have tested the changes locally and they are functioning as expected.
  • I have updated the documentation (if necessary) to reflect the changes.
  • I have added/updated relevant unit tests (if applicable).
  • I have ensured that my code follows the project's coding standards.
  • I have checked for any potential security issues and addressed them.
  • I have added necessary comments to the code, especially in complex or unclear sections.
  • I have rebased my branch on top of the latest main/master branch.

Additional Notes

Add any additional notes, context, or information that might be helpful for reviewers.

Reviewers

Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2

Definition of Done

  • Code is reviewed.
  • Code is tested.
  • Documentation is updated.
  • All checks and tests pass.
  • Approved by at least one reviewer.
  • Merged into the main/master branch.

@openshift-ci openshift-ci bot requested review from gparvin and ngraham20 January 28, 2026 15:59
@kurwang kurwang changed the title updating acm rbac roles ACM-26301 - ACM Roles - Finalize Jan 28, 2026
Copy link
Contributor

@mshort55 mshort55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kurwang
Copy link
Contributor Author

kurwang commented Jan 28, 2026

/assign @ngraham20

Copy link
Contributor

@ngraham20 ngraham20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jan 28, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kurwang, mshort55, ngraham20

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e0f32d8 into stolostron:main Jan 28, 2026
9 checks passed
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants