ci: skip production jobs on non-release PRs and pushes to main#33
Open
ci: skip production jobs on non-release PRs and pushes to main#33
Conversation
Add check-release-pr job to detect PRs that modify version.json. Production jobs now only run when: - Releaser workflow completes (workflow_run) - Manual trigger (workflow_dispatch) - Release PR validation (version.json changed) This eliminates wasteful production image builds and terraform plans on regular PRs and pushes to main, aligning with standard CI practices. Most importantly, this prevents developers from being confused when merging PRs. closes #32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR modifies the deploy workflow to skip production jobs on regular PRs and pushes to main. Production CI now runs only when actually relevant: during releases, manual triggers, or release PR validation.
Problem
The previous workflow ran production jobs—including Docker image pushes to production ECR and terraform plans—on every push to main and every PR. This behavior was:
Solution
Added a
check-release-prjob that detects whether a PR modifiesversion.json(the marker for release PRs). Production jobs now include conditions that skip execution unless one of the following is true:workflow_runevent (Releaser workflow completed)workflow_dispatchevent (manual)version.json(release validation)Behavior Matrix