feat: add blob/retrieve capability definition#52
Merged
Conversation
Peeja
approved these changes
Oct 6, 2025
Member
Peeja
left a comment
Peeja
left a comment
There was a problem hiding this comment.
LGTM with one semi-blocking question; feel free dismiss it if you've got a good answer.
| } | ||
|
|
||
| type RetrieveBlob struct { | ||
| digest Multihash |
Member
There was a problem hiding this comment.
question: Why put the digest inside another struct, rather than put it directly in the caveats? (Am I right that the RFC doesn't specify the caveats schema currently?)
Member
Author
There was a problem hiding this comment.
Just for consistency with types.Blob used in space/blob/add and space/content/retrieve.
| }) | ||
| } | ||
|
|
||
| func roundTripAgentMessage(t *testing.T, invs []invocation.Invocation, rcpts []receipt.AnyReceipt) message.AgentMessage { |
Member
There was a problem hiding this comment.
thought: This isn't specific to this capability, right? Should we (separately) use this for other tests, too?
Member
Author
There was a problem hiding this comment.
yes...yes we really should.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
blob/retrievecapability as proposed here storacha/RFC#68