Skip to content

ci: skip production jobs on non-release PRs and pushes to main #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
frrist wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: skip production jobs on non-release PRs and pushes to main #294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 33 additions & 1 deletion .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,25 @@ permissions:
contents: read # This is required for actions/checkout

jobs:
# Detect if this is a release PR (version.json changed)
check-release-pr:
runs-on: ubuntu-latest
if: ${{ github.event_name == 'pull_request' }}
outputs:
is-release: ${{ steps.check.outputs.is-release }}
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Check if version.json changed
id: check
run: |
if git diff --name-only origin/${{ github.base_ref }}...HEAD | grep -q "^version.json$"; then
echo "is-release=true" >> $GITHUB_OUTPUT
else
echo "is-release=false" >> $GITHUB_OUTPUT
fi

# apply staging on pushes to main, plan otherwise
staging:
uses: ./.github/workflows/terraform.yml
Expand Down Expand Up @@ -71,8 +90,14 @@ jobs:
cloudflare-api-token: ${{ secrets.WARM_STAGING_CLOUDFLARE_API_TOKEN }}
sentry-dsn: ${{ secrets.WARM_STAGING_SENTRY_DSN }}

# apply prod on successful release, plan otherwise
# Only run on: release PRs (plan), Releaser completion (apply), or manual dispatch
production:
needs: [check-release-pr]
if: ${{ always() && (
github.event_name == 'workflow_run' ||
github.event_name == 'workflow_dispatch' ||
(github.event_name == 'pull_request' && needs.check-release-pr.outputs.is-release == 'true')
Copy link
Member

@alanshaw alanshaw Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about merge release PR to main?

) }}
uses: ./.github/workflows/terraform.yml
with:
env: production
Expand All @@ -94,7 +119,14 @@ jobs:
honeycomb-api-key: ${{ secrets.PROD_HONEYCOMB_API_KEY }}
sentry-dsn: ${{ secrets.PROD_SENTRY_DSN }}

# Only run on: release PRs (plan), Releaser completion (apply), or manual dispatch
forge-production:
needs: [check-release-pr]
if: ${{ always() && (
github.event_name == 'workflow_run' ||
github.event_name == 'workflow_dispatch' ||
(github.event_name == 'pull_request' && needs.check-release-pr.outputs.is-release == 'true')
) }}
uses: ./.github/workflows/terraform.yml
with:
env: forge-prod
Expand Down
Loading