Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
alanshaw
approved these changes
Mar 13, 2026
volmedo
added a commit
that referenced
this pull request
Mar 13, 2026
Confirm that the fix in #298 works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When not using a custom value,
docker/metadata-actiontakes the ref fromgithub.ref. However, the value of that isrefs/heads/mainwhen the workflow is triggered byworkflow_run. That cannot be parsed into a semver, and the result is no tags in metadata, which then makes the docker push fail.The fix is to extract the value from what the
Determine refstep determines (which is the one that Releaser inferred fromversion.json). A match regex is also provided so that bothv1.2.3(what we will get whenworkflow_run) andrefs/tags/v1.2.3(what we will get when pushing a tag) work.