Merged
Conversation
frrist
approved these changes
Feb 2, 2026
Member
frrist
left a comment
frrist
left a comment
There was a problem hiding this comment.
Trusting this is mostly a mechanical change of things, LGTM
Comment on lines
+36
to
+52
| reqJ, err := json.Marshal( | ||
| struct { | ||
| Method string | ||
| Host string | ||
| Path string | ||
| Params string | ||
| ParamsSigned url.Values | ||
| Headers http.Header | ||
| }{ | ||
| Method: req.Method, | ||
| Host: req.Host, | ||
| Path: req.Path, | ||
| Params: req.Params.Encode(), | ||
| ParamsSigned: signedArgs, | ||
| Headers: req.Headers, | ||
| }, | ||
| ) |
Member
There was a problem hiding this comment.
Feels kinda weird to have this as an anonymous struct, your call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking to write a new client for this and the first step is to ensure we can test it against an API backend. This PR decouples the database layer from the API allowing an API to be run in tests that uses a mock backend.
This is mostly a mechanical change, however it does add a tested
spidpackage that allows parsing and formatting aFIL-SPID-V0header.refs storacha/spade-agent#7
resolves #13