Skip to content

fix: find tasks shouldn't poll providers #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
volmedo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: find tasks shouldn't poll providers #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions deploy/.env.production.local.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,7 @@ PREFIX="${TF_WORKSPACE}-${TF_VAR_app}"
"Publish": true,
"PublishExcept": null
},
"PollInterval": "24h0m0s",
"PollRetryAfter": "5h0m0s",
"PollStopAfter": "168h0m0s",
"PollOverrides": null,
"PollInterval": "0",
Copy link
Member

@alanshaw alanshaw Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the consequence if they do? Perhaps a comment here to explain why this is set to zero will help our future selves.

Copy link
Member Author

@volmedo volmedo Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the only consequence is that providers would receive pings from all the find tasks we deploy. Not that much of an issue, but unnecessary.

That code needs to be valid JSON so I can't just add a comment. Do you think adding a new _comment field would be worth it?

"UseAssigner": false
},
"Indexer": {
Expand Down
Loading