Open
Conversation
alanshaw
approved these changes
Jun 9, 2025
volmedo
force-pushed
the
vic/fix/registry-provider-rwmutex
branch
from
37f0dde to
daeec88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The registry uses a mutex to control access to the providers map. It is a regular mutex and it is used for both read and write operations. Go has a
RWMutexthat can differentiate when locking is requested for reads or writes. Using it can reduce contention in the lock, as reads don't need to be exclusive with other reads.This change should make the registry able to serve more requests, especially for find tasks where the vast majority of operations are reads.
I think this change is also useful for upstream, so I'll send a PR there too.
Proposed Changes
Replace
provMutexwith aRWMutexand check all it's usages to see which of them only need the read lock instead of the full lock.Tests
Testing all possible interactions between the different operations is unfeasible. Testing in staging will be our best bet IMO.