Closed
Conversation
hannahhoward
approved these changes
May 13, 2025
Member
hannahhoward
left a comment
There was a problem hiding this comment.
Lgtm and I prefer the rename to Principal if we have bandwidth to do it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the
didBytesschema so that it returns the type it is designed to read -Uint8Array. Concretely this changes the return type fromreadto be aPrincipalView, which is a subclass ofUint8Array.The issue is that while this schema (in its current form) can read and validate data encoded as a
Uint8Array, you cannot create an invocation/delegation with a value of aUint8Array- it expects a string DID:If you pass a string, it will be encoded as a string, which is not the value that can be read by the same schema.
In real terms, I'm trying to create a location claim with a byte encoded space DID but I cannot 😢
In hindsight, this schema type should perhaps be called
principal. I'd be open to changing this PR to add that and deprecatedidBytesinstead if folks feel strongly.