fixed issue 1080 #1081
Closed
fixed issue 1080 #1081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vojtechtrefny
left a comment
vojtechtrefny
left a comment
There was a problem hiding this comment.
I am not against merging this, but it feels like something that should be fixed in the code, not in tests. But I don't know enough about NVMe so I'll leave the decision on @tbzatek
tbzatek
requested changes
Dec 10, 2024
Member
tbzatek
left a comment
tbzatek
left a comment
There was a problem hiding this comment.
I would prefer to avoid using sleep for things where we can poll for something. In this case you may want to wait for specific subsystem nqn to appear in the list with certain timeout.
Member
|
Superseded by #1124 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.