Tests speedup #1119
Merged
Tests speedup #1119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only two test cases for the crypto plugin need two disks, we don't need to create two disks for all test cases.
Creating a LUKS format can be very slow so merging some of the similar test cases to one can speed up the tests significantly.
Some PBKDF parameters are valid for LUKS1 as well, we just cannot pass the extra parameters directly to crypt_format with LUKS1.
For tests cases like resize or status we can create LUKS with pbkdf2 and minimal iterations to speed up the tests significantly.
Two disks are needed just for a single btrfs multidevice test case
Most of the test cases don't need the spare so lets just use two disks for most of the tests.
No need to create the array three times just to test different ways to activate it.
No need to wait for resync with RAID0 and it doesn't change anything for this test case.
Two disks are needed just for one partition table test case.
vojtechtrefny
force-pushed
the
master_libblockdev-test-speedup
branch
from
68fab24 to
7eb0832
Compare
Mostly cosmetic stuff (indentation, unused variables...) but it also found few real issues like two test cases with the same name (so one of them wouldn't be executed).
vojtechtrefny
force-pushed
the
master_libblockdev-test-speedup
branch
from
eedccc5 to
77ec3a1
Compare
vojtechtrefny
merged commit 4a213b7
into
storaged-project:master
42 of 47 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The biggest change is using some extra pbkdf parameters when creating LUKS format to speedup the crypto tests and for other tests making sure we don't create more disks than needed.
On my machine on master the entire test suite currently takes about 2000 seconds, with these changes it's around 1400 seconds so 10 minutes less.