-
Notifications
You must be signed in to change notification settings - Fork 60
tests: Add a separate simpler MD activation test case #1144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Add a separate simpler MD activation test case #1144
Conversation
Summary of ChangesHello @vojtechtrefny, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a more stable and simplified test case for MD (de)activation functionality, specifically addressing frequent failures in existing tests on RHEL 9 and 10 caused by race conditions within Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
I don't like this, but having the tests failing all the time is not ideal. In the past I've definitely missed some more serious issues because I got used to seeing the tests "red" all the time. With this we'll get some coverage until the underlying mdadm issues are resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a simpler, more stable test case for MD RAID activation and deactivation to address flakiness in the existing tests. The new test, test_activate_deactivate_core, performs a basic sequence of creating, deactivating, activating, and deactivating a RAID0 array. The existing, more comprehensive test, test_activate_deactivate, has been marked as unstable. The changes are clear, logical, and effectively address the problem of test instability. The new test is well-implemented and consistent with the existing test suite's structure.
tbzatek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
w00t
MD (de)activation is currently very race-y in both RHEL 9 and 10 and then tests fails often especially when starting and stopping the array multiple times. This introduces a new simple test case that should cover most of the use cases without failing all the time keeping the "full" test case, but marking it as unstable until these issues are resolved in mdadm.
611bfc7 to
703186f
Compare
MD (de)activation is currently very race-y in both RHEL 9 and 10 and then tests fails often especially when starting and stopping the array multiple times. This introduces a new simple test case that should cover most of the use cases without failing all the time keeping the "full" test case, but marking it as unstable until these issues are resolved in mdadm.