lvm-dbus: Do not ignore rename fails in thpool/cachepool_convert

[vojtechtrefny]

This makes these function behave the same way the CLI plugin does when the final rename call fails.

Summary by CodeRabbit

• Bug Fixes
  • Fixed LVM thin pool and cache pool conversion operations to accurately report their final completion status. Operations now properly reflect the combined outcome of both pool creation and renaming steps, ensuring users receive reliable information about whether conversions ultimately succeed or fail.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b6322f78-6260-4586-a4cc-e116914f8dc2

📥 Commits

Reviewing files that changed from the base of the PR and between bdb48f4 and c33b0c4.

📒 Files selected for processing (1)

• src/plugins/lvm/lvm-dbus.c

---

📝 Walkthrough

Walkthrough

The change updates return-value handling in two LVM thin-pool and cache-pool conversion functions to ensure the final boolean return reflects the outcome of the rename operation when applicable, instead of only the pool-creation result.

Changes

Cohort / File(s)	Summary
LVM Return Value Handling src/plugins/lvm/lvm-dbus.c	Updated bd_lvm_thpool_convert and bd_lvm_cache_pool_convert to assign the rename operation result to ret instead of discarding it, ensuring the final return value reflects both pool creation and rename outcomes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: ensuring rename failures are not ignored in thpool/cachepool_convert functions.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}