feat(lib): change preview dimension #463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
johannes-lindgren
changed the title
johannes-lindgren
changed the title
Dawntraoz
reviewed
Jul 23, 2025
Dawntraoz
reviewed
Jul 23, 2025
...plugin/src/messaging/pluginMessage/pluginToContainerMessage/PreviewDimensionChangeMessage.ts
Outdated
Show resolved
Hide resolved
packages/field-plugin/src/createFieldPlugin/FieldPluginActions.ts
Outdated
Show resolved
Hide resolved
Dawntraoz
approved these changes
Jul 25, 2025
demetriusfeijoo
previously approved these changes
Jul 25, 2025
There was a problem hiding this comment.
Nice job and great addition @johannes-lindgren @fernandacanto 🔥 🔥
Tested in both Sandbox and Storyfront, and everything worked like a charm.
demetriusfeijoo
dismissed
their stale review
Investigating a possible bug a just found
packages/field-plugin/src/createFieldPlugin/createPluginActions/createPluginActions.ts
Show resolved
Hide resolved
demetriusfeijoo
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Jira issue: SHAPE-11026
PR for change in storyfront: https://github.com/storyblok/storyfront/pull/8231
Allow field plugins to change the preview dimension (mobile/tablet/desktop/custom)
How to test? (optional)