refactor: make bridge key in useAsyncStoryblok optional#231
Open
m-shum wants to merge 6 commits intostoryblok:mainfrom
Open
refactor: make bridge key in useAsyncStoryblok optional#231m-shum wants to merge 6 commits intostoryblok:mainfrom
bridge key in useAsyncStoryblok optional#231m-shum wants to merge 6 commits intostoryblok:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bridgean optional key inUseAsyncStoryblokOptions. This seeks to remove the need to pass a redundant empty bridge options property inuseAsyncStoryblokwhere bridge options are not needed.UseAsyncStoryblokOptionsinterface frompackages/nuxt/src/runtime/composables/useAsyncStoryblok.ts& imports it frompackages/nuxt/src/types/index.tsinstead to maintain a single source of truthscript setuplang totsacross/playgroundand/playground-e2epages for clearer typescript error handlingdev:preparescript in line with the Nuxt module builder (see here)useAsyncStoryblokacross/playgroundand/playground-e2e