feat(stories): Add published_at_gt and other date related query parameters
#65
Conversation
src/Domain/Value/QueryParameter/FirstPublishedAtQueryParameter.php
Outdated
Show resolved
Hide resolved
|
|
||
| namespace Storyblok\Api\Domain\Value\QueryParameter; | ||
|
|
||
| final readonly class FirstPublishedAtQueryParameter extends DateQueryParameter |
There was a problem hiding this comment.
| final readonly class FirstPublishedAtQueryParameter extends DateQueryParameter | |
| final readonly class FirstPublishedAt |
There was a problem hiding this comment.
I am using FirstPublishedAtGt... now. I would prefer new FirstPublishedAtGt rather than new FirstPublishedAt($dateTime, '<some enum>');
There was a problem hiding this comment.
Why not passing an argument which is an enum? Such as
new FirstPublishedAt(direction: Direction::LT)
There was a problem hiding this comment.
Because the query parameter is named like this "first_published_at_gt" or "first_published_at_lt". I think it is more intuitive for the developer to use a value object that is directly named like the query parameter itself.
In this case it is not like in the sort_by parameter where the direction is used as value for some field.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #65 +/- ##
============================================
+ Coverage 93.88% 93.91% +0.02%
- Complexity 461 488 +27
============================================
Files 72 79 +7
Lines 1620 1675 +55
============================================
+ Hits 1521 1573 +52
- Misses 99 102 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OskarStark
changed the title
published_at_gt and other date related query parameters (#64)published_at_gt and other date related query parameters
|
Any further feedback? |
Adds support for these query parameters:
published_at_gtpublished_at_ltfirst_published_at_gtfirst_published_at_ltupdated_at_gtupdated_at_ltMore about this topic in the issue: #64