Skip to content

feat: Port to Storybook 9 #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sidnioulz merged 8 commits into from
Jun 3, 2025
Merged

feat: Port to Storybook 9 #31

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
69a92e8
feat: Port to Storybook 9
Sidnioulz Jun 2, 2025
5a08ab0
chore: Update package manager to pnpm@10.7.0 and clean up tarball URL…
ndelangen Jun 2, 2025
035c51b
chore: Add Storybook as a peer dependency and update package manager …
ndelangen Jun 2, 2025
1899845
chore: Disable sourcemaps in tsup configuration
ndelangen Jun 2, 2025
738be3d
chore: Update release workflow and package.json scripts
ndelangen Jun 2, 2025
b0abbb4
chore: Remove pnpm version specification from release workflow
ndelangen Jun 2, 2025
6523468
chore: Add dependency installation step to release workflow
ndelangen Jun 2, 2025
6935319
chore: Let auto handle versioning
Sidnioulz Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 11 additions & 25 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,39 +7,25 @@ jobs:
runs-on: ubuntu-latest
if: "!contains(github.event.head_commit.message, 'ci skip') && !contains(github.event.head_commit.message, 'skip ci')"
steps:
- uses: actions/checkout@v2

- name: Prepare repository
run: git fetch --unshallow --tags

- name: Use Node.js 18.x
uses: actions/setup-node@v3
- uses: actions/checkout@v4
with:
node-version: 18.x
fetch-depth: 0

- uses: pnpm/action-setup@v2
name: Install pnpm
- name: Use Node.js 20.x
uses: actions/setup-node@v3
with:
version: 8
run_install: false
node-version: 20.x

- name: Get pnpm store directory
shell: bash
run: |
echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV

- uses: actions/cache@v3
name: Setup pnpm cache
with:
path: ${{ env.STORE_PATH }}
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-pnpm-store-
- uses: pnpm/action-setup@v4

- name: Install dependencies
run: pnpm install

- name: Create Release
- name: Build
run: |
pnpm build

- name: Release
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18
20
33 changes: 16 additions & 17 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@storybook/addon-styling-webpack",
"version": "1.0.1",
"version": "2.0.0",
Copy link
Member Author

@Sidnioulz Sidnioulz Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note: I've bumped the version as I saw Shaun was doing it himself and I suspect it's not auto-managed. If version is managed via release commits (using Shaun's identity 😬), this will need to be reverted.

Copy link
Member Author

@Sidnioulz Sidnioulz Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mental note: must definitely be reverted. Will do it later so as not to mess up with your branch history while you're working on this, Norbert.

"description": "A base addon for configuring popular styling tools in Webpack",
"keywords": [
"style",
Expand All @@ -20,14 +20,14 @@
},
"exports": {
".": {
"types": "./dist/index.d.ts",
"require": "./dist/index.js",
"import": "./dist/index.mjs",
"types": "./dist/index.d.ts"
"import": "./dist/index.mjs"
},
"./preset": {
"types": "./dist/preset.d.ts",
"require": "./dist/preset.js",
"import": "./dist/preset.mjs",
"types": "./dist/preset.d.ts"
"import": "./dist/preset.mjs"
Comment on lines +23 to +30
Copy link
Member Author

@Sidnioulz Sidnioulz Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed import order warning in more recent bundlers

},
"./package.json": "./package.json",
"./postinstall": "./postinstall.js"
Expand All @@ -45,24 +45,23 @@
"scripts": {
"build": "tsup",
"build:watch": "pnpm build --watch",
"clean": "rimraf dist && rimraf bin",
"release": "pnpm build && auto shipit"
},
"dependencies": {
"@storybook/node-logger": "^8.0.0-alpha.10"
"release": "auto shipit"
},
"devDependencies": {
"@types/node": "^18.0.0",
"auto": "^11.1.1",
"prettier": "^3.2.0",
"rimraf": "^3.0.2",
"tsup": "^6.7.0",
"typescript": "^5.3.0",
"webpack": "^5.0.0"
"@types/node": "^22.15.29",
"auto": "^11.3.0",
"prettier": "^3.5.3",
"rimraf": "^6.0.1",
"storybook": "^9.0.4",
Copy link
Member Author

@Sidnioulz Sidnioulz Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of node-logger which has been internalised.

"tsup": "^8.5.0",
"typescript": "^5.8.3",
"webpack": "^5.99.9"
},
"peerDependencies": {
"storybook": "^9.0.0",
"webpack": "^5.0.0"
},
"packageManager": "pnpm@10.7.0+sha512.6b865ad4b62a1d9842b61d674a393903b871d9244954f652b8842c2b553c72176b278f64c463e52d40fff8aba385c235c8c9ecf5cc7de4fd78b8bb6d49633ab6",
"publishConfig": {
"access": "public"
},
Expand Down
Loading