Skip to content

Upgrade addon to be compatible with Storybook v10#33

Merged
ndelangen merged 6 commits intostorybookjs:mainfrom
MaxLikesCode:main
Nov 11, 2025
Merged

Upgrade addon to be compatible with Storybook v10#33
ndelangen merged 6 commits intostorybookjs:mainfrom
MaxLikesCode:main

Conversation

@MaxLikesCode
Copy link
Contributor

Summary

This PR upgrades the addon to be compatible with Storybook v10, migrating from Storybook v9. The changes include dependency updates and a migration to pure ESM format.

Changes

  • Storybook version upgrade: Updated from ^9.0.0 to ^10.0.0 in both devDependencies and peerDependencies
  • ESM migration: Converted the package from dual ESM/CJS to pure ESM format
    • Removed require fields from package.json exports
    • Added "type": "module" to package.json
    • Updated tsup configuration to build only ESM format (format: ["esm"])
    • Updated import statements to use .js extensions (required for ESM)
  • Dependency updates: Updated lockfile with Storybook v10 and related dependencies

Breaking Changes

⚠️ This is a breaking change. The package now:

  • Only supports ESM imports (no CommonJS require)
  • Requires Storybook v10+

Related

@krzysiek1507
Copy link

Hey @Sidnioulz! Would you mind reviewing it?

@Sidnioulz Sidnioulz self-assigned this Nov 10, 2025
Copy link
Member

@Sidnioulz Sidnioulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @MaxLikesCode!

There are changes missing from the addon migration guide, in particular in tsup and tsconfig, and in the src/index. There are also changes to how addons are locally loaded which may need to be taken into account.

Could you please go through the guide step by step and ensure these are updated?

… consistent engine specifications across dependencies
Copy link
Member

@Sidnioulz Sidnioulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See suggestions

Co-authored-by: Steve Dodier-Lazaro <Sidnioulz@users.noreply.github.com>
@ndelangen ndelangen merged commit e19567f into storybookjs:main Nov 11, 2025
@krzysiek1507
Copy link

Seems like auto-release failed :(

@vlysytsia
Copy link

@ndelangen @Sidnioulz can you please check the release for this PR as addon-styling-webpack still doesn't work with Storybook v10

@Sidnioulz
Copy link
Member

@ndelangen @Sidnioulz can you please check the release for this PR as addon-styling-webpack still doesn't work with Storybook v10

I can see the release was performed on November 13. Could you please open a new issue with the errors you're finding and more information on your environment (framework, Node version, OS, features used, reproduction repository)? Thanks

@vlysytsia
Copy link

@ndelangen @Sidnioulz can you please check the release for this PR as addon-styling-webpack still doesn't work with Storybook v10

I can see the release was performed on November 13. Could you please open a new issue with the errors you're finding and more information on your environment (framework, Node version, OS, features used, reproduction repository)? Thanks

Thanks for reply @Sidnioulz, I added the issue #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants