fix: use correct color for bar text#689
Merged
dannyhw merged 3 commits intostorybookjs:nextfrom Feb 27, 2025
Merged
Conversation
Member
|
the text seems quite muted specifically on the dark mode, it makes me wonder if the background colour might be also off slightly |
Contributor
Author
|
Good catch, the background is the same, but there is a very slight difference in the text colour. Before (my original commit) and after on iOS.
|
alcpereira
force-pushed
the
fix/bar-text-color
branch
from
0355245 to
0e505ae
Compare
alcpereira
force-pushed
the
fix/bar-text-color
branch
from
0e505ae to
a843d7f
Compare
dannyhw
approved these changes
Feb 27, 2025
Member
dannyhw
left a comment
dannyhw
left a comment
There was a problem hiding this comment.
Sorry for the delay, looks good to me!
Thanks for contributing 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: part of #686 (I will do smaller and individual PR to avoid just shipping a bunch of changes at once)
What I did
Fixed the "Bar Text" font and use the already available
theme.barTextColorinstead.How to test
Try with Expo sandboxes
Screenshots