Merged
Conversation
fabioatcorreia
approved these changes
Feb 24, 2025
Contributor
fabioatcorreia
left a comment
There was a problem hiding this comment.
Just tested and it is working smoothly for me in a React Native CLI Storybook app 💯
Member
Author
|
@fabioatcorreia awesome! thanks for testing 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
Adds the ability to link directly to a story without requiring user land code.
This using the react native Linking api directly so assuming your app is configured for deeplinks then you can navigate via deeplinks by passing the STORYBOOK_STORY_ID search param if storybook is being rendered
[scheme]://[url]?STORYBOOK_STORY_ID=[story_id]This could potentially be used by testing tools like maestro to set the story without interacting with the ui meaning that you can disable the ondevice ui and just navigate purely through linking calls and take screenshots or interact with components.
In the expo go example app for example you can now do this and it will take you to those stories.
npx uri-scheme open "exp://127.0.0.1:8081/--/?STORYBOOK_STORY_ID=controlexamples-boolean--basic" --iosor this:
npx uri-scheme open "exp://127.0.0.1:8081/--/?STORYBOOK_STORY_ID=controlexamples-controlexample--example" --iosdeeplinkstorybook.mp4
storybookdeeplink.mp4
How to test
Please explain how to test your changes and consider the following questions
If your answer is yes to any of these, please make sure to include it in your PR.