Skip to content

Svelte: Update portable-stories snapshots#34067

Draft
kasperpeulen wants to merge 4 commits intonextfrom
codex/fix-next-svelte-snapshots
Draft

Svelte: Update portable-stories snapshots#34067
kasperpeulen wants to merge 4 commits intonextfrom
codex/fix-next-svelte-snapshots

Conversation

@kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Mar 8, 2026

Closes #

What I did

Updated the Svelte portable-stories kitchen sink snapshots to match the current DOM output on next, fixing the failing portable-stories-kitchen-sink/svelte:vitest:production CI task.

Note: the unrelated tests-stories--linux failure in core/src/manager/components/layout/Layout.stories.tsx was tracked separately and has since been fixed on next in #34072 (Tests: Fix Layout story unduly failing).

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Caution

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

No manual testing was performed; this is a snapshot-only update for existing automated test output.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

@kasperpeulen kasperpeulen added build Internal-facing build tooling & test updates ci:merged Run the CI jobs that normally run when merged. labels Mar 8, 2026
@kasperpeulen kasperpeulen changed the title Test: update Svelte portable-stories snapshots Svelte: Update portable-stories snapshots Mar 8, 2026
@kasperpeulen kasperpeulen marked this pull request as draft March 8, 2026 05:02
@nx-cloud
Copy link

nx-cloud bot commented Mar 8, 2026

View your CI Pipeline Execution ↗ for commit 718167e

Command Status Duration Result
nx run-many -t compile -c production --parallel=1 ✅ Succeeded 4m 46s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-08 10:46:38 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:merged Run the CI jobs that normally run when merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant