CI: Allow the GitHub Actions bot to commit to release branches#34076
CI: Allow the GitHub Actions bot to commit to release branches#34076
Conversation
|
View your CI Pipeline Execution ↗ for commit 2530244
☁️ Nx Cloud last updated this comment at |
|
View your CI Pipeline Execution ↗ for commit 8c7472f ☁️ Nx Cloud last updated this comment at |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughExtends the skip condition in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
✨ Finishing Touches
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@scripts/dangerfile.js`:
- Around line 150-157: The code incorrectly reads danger.github.pr.author into
the variable author causing undefined for contributor PRs; update the assignment
to use danger.github.pr.user instead and ensure subsequent checks that reference
author (and authorAssociation) still work (the conditional that checks
['OWNER','MEMBER'].includes(authorAssociation) and the bot check that uses
author.login and author.type should operate on the new author variable). Locate
the author/authorAssociation initialization and replace the source for author
from pr.author to pr.user so the bot/type access no longer throws a TypeError.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d1e979b3-df2b-4cae-9806-6dc9d392707f
📒 Files selected for processing (1)
scripts/dangerfile.js
What I did
Allowed GitHub Actions Bot to bypass the PR branch check.
Checklist for Contributors
Testing
ø
Manual testing
ø (needs to be merged to test it)
Summary by CodeRabbit