fix(vue3): clear stale args/globals when nextArgs is empty in updateArgs

[mixelburg]

What does this PR do?

Fixes the bug where stale args/globals persisted in Vue decorators after resetting args or clearing toolbar globals.

When updateArgs() was called with an empty nextArgs object, the early return on line 156 skipped the deletion loop entirely. This left every existing key in reactiveArgs/reactiveGlobals alive, so resetting args or clearing toolbar globals back to {} had no effect on the Vue reactive objects.

Fix

Remove the early return so the deletion loop always runs. When nextArgs is {}, all keys in currentArgs are deleted, resulting in a properly empty reactive object.

Test

Added a regression test: updateArgs(reactive({ argFoo: 'foo', argBar: 'bar' }), {}) now results in an empty object.

Fixes #34319

Summary by CodeRabbit

Bug Fixes

• Fixed Vue3 renderer to properly clear component arguments when updating with empty values. Previously, the renderer would skip processing updates if an empty object was provided. Now it correctly removes arguments not included in new values.

Tests

• Added test coverage to verify argument clearing works correctly during updates.

[coderabbitai]

📝 Walkthrough

Walkthrough

The updateArgs function in the Vue3 renderer was modified to remove an early-exit guard that prevented execution when nextArgs was empty. This allows the function to proceed through its logic and clear previously-held arguments when an empty object is passed. A new test verifies this behavior.

Changes

Cohort / File(s)	Summary
Vue3 Renderer updateArgs Implementation code/renderers/vue3/src/render.ts	Removed early-exit guard that returned when nextArgs had zero keys, enabling the function to clear existing reactive arguments when an empty object is provided.
Vue3 Renderer Tests code/renderers/vue3/src/render.test.ts	Added new test case verifying that updateArgs(reactiveArgs, {}) clears reactive argument state entirely.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• Vue: Make globals reactive in decorators #33562 — Modifies Vue3 renderer's updateArgs implementation and its tests for handling reactive argument and global updates.
• Vue: Make globals reactive in decorators #34116 — Updates the same updateArgs implementation in Vue3 renderer to make it generic and add support for reactive globals.
• Revert "Vue: Make globals reactive in decorators" #33744 — Modifies the same updateArgs implementation in Vue3 renderer, changing its behavior and signature along with corresponding tests.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

code/renderers/vue3/src/render.test.ts (1)

94-98: Good regression test for the empty nextArgs fix.

The test correctly covers the scenario from issue #34319. One minor suggestion: consider using the generic type parameter pattern already established elsewhere in this file (lines 28, 42, 58) instead of the as any cast for better type safety.

♻️ Suggested type-safe alternative

  it('clears all args when nextArgs is empty -> updateArgs()', () => {
    const reactiveArgs = reactive({ argFoo: 'foo', argBar: 'bar' });
-   updateArgs(reactiveArgs, {} as any);
+   updateArgs<Args>(reactiveArgs, {});
    expect(reactiveArgs).toEqual({});
  });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@code/renderers/vue3/src/render.test.ts` around lines 94 - 98, The test uses
an unsafe cast (`as any`) when calling updateArgs; replace that cast with the
generic type parameter pattern used elsewhere in this file by invoking
updateArgs with the inferred/explicit generic for the reactiveArgs variable
(e.g., use the same generic style as the other tests instead of `as any`) so the
call to updateArgs(reactiveArgs, ...) is type-safe; update the invocation that
references updateArgs and reactiveArgs to use the generic type parameter form.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@code/renderers/vue3/src/render.test.ts`:
- Around line 94-98: The test uses an unsafe cast (`as any`) when calling
updateArgs; replace that cast with the generic type parameter pattern used
elsewhere in this file by invoking updateArgs with the inferred/explicit generic
for the reactiveArgs variable (e.g., use the same generic style as the other
tests instead of `as any`) so the call to updateArgs(reactiveArgs, ...) is
type-safe; update the invocation that references updateArgs and reactiveArgs to
use the generic type parameter form.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d6869e50-8679-4dc5-a7ba-be406ffce20c

📥 Commits

Reviewing files that changed from the base of the PR and between 1c38a36 and e406caa.

📒 Files selected for processing (2)

• code/renderers/vue3/src/render.test.ts
• code/renderers/vue3/src/render.ts

💤 Files with no reviewable changes (1)

• code/renderers/vue3/src/render.ts