feat(react): capture runtime props without wrapping user components#1
Open
yann-copilot wants to merge 4 commits intostorybookjs:mainfrom
Open
feat(react): capture runtime props without wrapping user components#1yann-copilot wants to merge 4 commits intostorybookjs:mainfrom
yann-copilot wants to merge 4 commits intostorybookjs:mainfrom
Conversation
4af60dd to
ea8ddde
Compare
ea8ddde to
c1227b5
Compare
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This proposes a React-only alternative that captures runtime props without transforming user component declarations into wrappers.
What changed
src/frameworks/react/transform.tswithComponentHighlighter(...)virtual:component-highlighter/runtime) for React files with JSXsrc/frameworks/react/runtime-module.tsmemoizedPropsand resolve nearest host elementWhy
Current implementation mutates user source shape by adding wrappers, which is intrusive and can affect debugging/tooling expectations.
This keeps original component structure intact while still collecting runtime props for the highlighter/story generation workflow.
Scope
Caveats
__reactContainer$/__reactFiber$and fiber shape), so this is intentionally experimental and may require maintenance across React updates.