Fix: Correct aria-label for Discord social link#375
Open
huangkevin-apr wants to merge 1 commit intostorybookjs:mainfrom
Open
Fix: Correct aria-label for Discord social link#375huangkevin-apr wants to merge 1 commit intostorybookjs:mainfrom
huangkevin-apr wants to merge 1 commit intostorybookjs:mainfrom
Conversation
👷 Deploy request for storybook-addon-catalog pending review.Visit the deploys page to approve it
|
👷 Deploy request for storybook-frontpage pending review.Visit the deploys page to approve it
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the accessibility issue where the Discord social media link in the footer was incorrectly labeled as "Storybook" instead of "Discord".
Solved Issue
Close #374
The Discord icon link had a misleading aria-label attribute that would cause screen reader users to hear "Storybook" when the link actually points to Discord. This created confusion and violated WCAG 2.1 accessibility standards.
As shown in screenshot, all other social media links (GitHub, BlueSky, Twitter, YouTube) have correct aria-label values matching their respective platforms. Only the Discord link has this mismatch.
Solution
Changed the name prop of the Circle component from "Storybook" to "Discord" to ensure the accessible label matches the visual icon and link destination.