Fix error in the comment for the registerGroupAndAttachLicense method#373
Closed
intls wants to merge 2 commits intostoryprotocol:devfrom
Closed
Fix error in the comment for the registerGroupAndAttachLicense method#373intls wants to merge 2 commits intostoryprotocol:devfrom
registerGroupAndAttachLicense method#373intls wants to merge 2 commits intostoryprotocol:devfrom
Conversation
intls
requested review from
AndyBoWu,
DonFungible,
LeoHChen,
allenchuang,
edisonz0718 and
jacob-tucker
as code owners
bonnie57
reviewed
Mar 3, 2025
Contributor
bonnie57
left a comment
bonnie57
left a comment
There was a problem hiding this comment.
Hi @intls ,
Thank you so much for your contribution and for taking the time to submit this PR! We really appreciate your effort and insights.
It looks like the code in this PR is outdated, and we’ve already addressed the documentation errors.
For now, I’ll go ahead and close this PR, but please don’t hesitate to reach out if you have any further suggestions or questions. Your contributions are always welcome!
Thanks again for your support and for helping us improve! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the parameter description,
request.pIdsis specified, whereas in the code, the method receives and processes the arrayrequest.ipIds. This is a typo in the documentation, which can confuse developers when using the method.