Conversation
bonnie57
requested review from
AndyBoWu,
DonFungible,
LeoHChen,
allenchuang,
bpolania,
edisonz0718 and
jacob-tucker
as code owners
DracoLi
approved these changes
Feb 20, 2025
bonnie57
force-pushed
the
bonnie/dev2
branch
from
fe0bb1e to
2f1443e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
1. Add Auto Wrapping Support to the following ipAsset functions
mintAndRegisterIp: Pay nft minting feeregisterDerivative2. Add following methods to
nftClient. This is to allow dev to easily to get the mint fee of a SPG collection.mintFeeToken: Gets the mint fee token of an spg nft contractmintFee: Gets the mint fee of an spg nft contractThrow error more specify when call getRevenueShare method
4. Add
urivalue for each PIL Flavor by default5. Make allowDuplicates optional
6. Bind link with v1.3.1