Skip to content

Bump up version to 1.3.0.rc.1#434

Merged
bonnie57 merged 71 commits intomainfrom
dev
Mar 4, 2025
Merged

Bump up version to 1.3.0.rc.1#434
bonnie57 merged 71 commits intomainfrom
dev

Conversation

@bonnie57
Copy link
Contributor

@bonnie57 bonnie57 commented Feb 21, 2025

Description

1. Auto Wrapping Support for ipAsset Methods

  • Methods Affected:
    • mintAndRegisterIp
    • registerDerivative
  • Changes: Added automatic wrapping support for these methods to streamline the process of minting and registering IP assets and derivatives.

2. New Methods Added

nftClient Module:

  • getMintFeeToken: Retrieves the mint fee token for an SPG NFT contract.
  • getMintFee: Retrieves the mint fee for an SPG NFT contract.

dispute Module:

  • tagIfRelatedIpInfringed: Enhanced to handle multiple IpId inputs with multicall support. Added useMulticallWhenPossible option for efficiency.
  • disputeAssertion: Counters a dispute that was raised by another party on an IP using counter evidence that is uploaded to IPFS.
  • disputeIdToAssertionId: Query the assertion id for a given dispute id

WIP Module:

  • transfer: Added method to transfer WIP tokens.
  • transferFrom: Added method to transfer WIP tokens on behalf of another address.

Royalty Module:

  • batchClaimAllRevenue: The method allows batching multiple claimAllRevenue requests. When called, it will claim all revenue from the child IPs of the provided ancestor IPs.

3. Auto ERC20 Approval for payRoyaltyOnBehalf

  • Method Affected: payRoyaltyOnBehalf in the royalty client.
  • Changes: The method now automatically approves ERC20 tokens for royalty payments if the allowance is insufficient. Previously, this functionality was limited to WIP tokens.

4. Default Values for DerivativeData and LicenseConfig

Derivative Data:

  • Default Values:
    • maxMintingFee: 0
    • maxRts: 100_000_000
    • maxRevenueShare: 100 (percentage, SDK converts to 100m before protocol call)

Licensing Config:

  • Default Values (if not provided):
    • isSet: false
    • mintingFee: 0
    • licensingHook: zeroAddress
    • hookData: zeroAddress
    • commercialRevShare: 0
    • disabled: false
    • expectMinimumGroupRewardShare: 0
    • expectGroupRewardPool: zeroAddress

5. Other Changes

  • Error Handling: Improved error specificity for the getRevenueShare method.
  • PIL Flavor URIs: Added default uri values for each PIL Flavor.
  • Optional Parameter: Made allowDuplicates optional.
  • Event Linking: Bound events to the v1.3.1 tag of smart contracts.
  • Method Update: Updated contractCallWithWipFees to accept both ERC20 and Wrapper IP.
  • Type Exports: Exported types related to the WIP client, including ERC20Options, WipOptions, license config,license terms data and TransactionResponse.
  • Documentation: Added detailed documentation about bond and liveness in the raiseDispute method of the dispute module.
  • Block Creation Fields: Updated block creation fields for both mainnet and Aeneid chain using data from the blockchain explorer.
  • Unit Tests: Added unit tests for the Wrapper and other components as needed.
  • Integration tests: Enhance dispute module integration tests
  • Fix issue about derivativesAllowed and derivativesAttribution
  • Update IPA Metadata Standard

Test Plan

Integration test
image

bpolania and others added 30 commits February 12, 2025 15:56
…ement-day

Dispute Integration tests fixed and expanded
* Add more methods from smart contracts

* Add tagIfRelatedIpInfringed method

* Add transfer,transferFrom method in wip module

* Add unit for transfer and transferFrom methods

* Update blockCreated including aeneid and mainnet

* Rename HandleTxOptionsResponse to TransactionResponse

* Implement auto approve about payRoyaltyOnBehalf method

* Enhance tagIfRelatedIpInfringed method

* Refactor code about contractCallWithFees

* Fix tests including unit and integration tests

* Enhance tagIfRelatedIpInfringed method

* Export the related types

* Modify typo

* Resolve dispute conflict and enhance the module integration test

* Refactor via comments

* Add todo to wait for confirmation

* Separate ERC20Options and WIPOptions

* Update the doc

* Update the doc about livenss unit

* Refactor via commits

* Refactor via comments

* Refactor via comments
Add default value for LicenseConfig

Update the doc about multiple line

Update the doc

Update event with link

Update zero address

Modify licenseConfig logic

Refactor via comments

Enhance LicenseTermsData type

Make licensingConfig required in the setLicensingConfig method

Update default show style
Add default value for DerivativeData and LicenseConfig
1. Add new methods for nftClient
2. Bind link with v1.3.1
3. Make allowDuplicates optional
edisonz0718
edisonz0718 previously approved these changes Feb 27, 2025
DracoLi and others added 2 commits March 1, 2025 08:07
* Fix issue about derivativesAllowed and derivativesAttribution

Skip the dispute assertion

* Update dispute assert test
@bonnie57 bonnie57 changed the title Bump up version to 1.3.0-rc.1 Bump up version to 1.3.0.rc.1 Mar 3, 2025
@bonnie57 bonnie57 merged commit 708233e into main Mar 4, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants