Conversation
…ement-day Dispute Integration tests fixed and expanded
* Add more methods from smart contracts * Add tagIfRelatedIpInfringed method * Add transfer,transferFrom method in wip module * Add unit for transfer and transferFrom methods * Update blockCreated including aeneid and mainnet * Rename HandleTxOptionsResponse to TransactionResponse * Implement auto approve about payRoyaltyOnBehalf method * Enhance tagIfRelatedIpInfringed method * Refactor code about contractCallWithFees * Fix tests including unit and integration tests * Enhance tagIfRelatedIpInfringed method * Export the related types * Modify typo * Resolve dispute conflict and enhance the module integration test * Refactor via comments * Add todo to wait for confirmation * Separate ERC20Options and WIPOptions * Update the doc * Update the doc about livenss unit * Refactor via commits * Refactor via comments * Refactor via comments
Add default value for LicenseConfig Update the doc about multiple line Update the doc Update event with link Update zero address Modify licenseConfig logic Refactor via comments Enhance LicenseTermsData type Make licensingConfig required in the setLicensingConfig method Update default show style
Add default value for DerivativeData and LicenseConfig
1. Add new methods for nftClient 2. Bind link with v1.3.1 3. Make allowDuplicates optional
…enue Add batched claim all revenue method
Update to IPA Metadata Standard
chore: export license config and license terms data
feat: Add dispute assertion to dispute client
edisonz0718
previously approved these changes
Feb 27, 2025
feat: add bonnie as reviewer
* Fix issue about derivativesAllowed and derivativesAttribution Skip the dispute assertion * Update dispute assert test
DracoLi
approved these changes
Mar 3, 2025
edisonz0718
approved these changes
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
1. Auto Wrapping Support for
ipAssetMethodsmintAndRegisterIpregisterDerivative2. New Methods Added
nftClientModule:getMintFeeToken: Retrieves the mint fee token for an SPG NFT contract.getMintFee: Retrieves the mint fee for an SPG NFT contract.disputeModule:tagIfRelatedIpInfringed: Enhanced to handle multipleIpIdinputs withmulticallsupport. AddeduseMulticallWhenPossibleoption for efficiency.disputeAssertion: Counters a dispute that was raised by another party on an IP using counter evidence that is uploaded to IPFS.disputeIdToAssertionId: Query the assertion id for a given dispute idWIPModule:transfer: Added method to transfer WIP tokens.transferFrom: Added method to transfer WIP tokens on behalf of another address.RoyaltyModule:batchClaimAllRevenue: The method allows batching multipleclaimAllRevenuerequests. When called, it will claim all revenue from the child IPs of the provided ancestor IPs.3. Auto ERC20 Approval for
payRoyaltyOnBehalfpayRoyaltyOnBehalfin theroyaltyclient.4. Default Values for
DerivativeDataandLicenseConfigDerivative Data:
maxMintingFee: 0maxRts: 100_000_000maxRevenueShare: 100 (percentage, SDK converts to 100m before protocol call)Licensing Config:
isSet: falsemintingFee: 0licensingHook: zeroAddresshookData: zeroAddresscommercialRevShare: 0disabled: falseexpectMinimumGroupRewardShare: 0expectGroupRewardPool: zeroAddress5. Other Changes
getRevenueSharemethod.urivalues for each PIL Flavor.allowDuplicatesoptional.v1.3.1tag of smart contracts.contractCallWithWipFeesto accept both ERC20 and Wrapper IP.WIP client, includingERC20Options,WipOptions,license config,license terms dataandTransactionResponse.bondandlivenessin theraiseDisputemethod of thedisputemodule.mainnetandAeneidchain using data from the blockchain explorer.Wrapperand other components as needed.disputemodule integration testsderivativesAllowedandderivativesAttributionIPA MetadataStandardTest Plan
Integration test
