feat: add getNFTBalance to NftClient for querying NFT count per colle…#698
Merged
yingyangxu2026 merged 2 commits intomainfrom Feb 27, 2026
Merged
feat: add getNFTBalance to NftClient for querying NFT count per colle…#698yingyangxu2026 merged 2 commits intomainfrom
yingyangxu2026 merged 2 commits intomainfrom
Conversation
Collaborator
yingyangxu2026
commented
Feb 25, 2026
yingyangxu2026
commented
- Add balanceOf to SPGNFTImpl whiteList in wagmi config and regenerate ABI
- Implement getNFTBalance in NftClient to return NFT count for an address in a given SPG collection
- Add GetNFTBalanceRequest type with optional owner (defaults to connected wallet)
- Add unit tests (2) and integration tests (2) for getNFTBalance
- Decouple nftClient integration tests: move collection setup to top-level before hook, add self-contained before for getNFTBalance
- Fix Evaluate type import: remove non-exported Evaluate from @wagmi/cli, use local type and Omit<ContractConfig, "abi">
yingyangxu2026
requested review from
DonFungible,
LeoHChen,
allenchuang,
jacob-tucker,
limengformal and
lucas2brh
as code owners
yingyangxu2026
had a problem deploying
to
odyssey
GitHub Actions
Failure
yingyangxu2026
had a problem deploying
to
odyssey
GitHub Actions
Failure
yingyangxu2026
had a problem deploying
to
odyssey
GitHub Actions
Failure
yingyangxu2026
temporarily deployed
to
odyssey
GitHub Actions
Inactive
lucas2brh
approved these changes
Feb 27, 2026
chao-peng-story
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.