Skip to content

docs(bedrock): update S3 location examples to use new location pattern#672

Merged
zastrowm merged 1 commit intomainfrom
update-s3-location-pattern
Mar 18, 2026
Merged

docs(bedrock): update S3 location examples to use new location pattern#672
zastrowm merged 1 commit intomainfrom
update-s3-location-pattern

Conversation

@zastrowm
Copy link
Copy Markdown
Member

@zastrowm zastrowm commented Mar 17, 2026

Description

Update S3 location documentation to match latest typescript implementation.

Related Issues

N/A

Type of Change

  • Bug fix

Checklist

  • I have read the CONTRIBUTING document
  • My changes follow the project's documentation style
  • I have tested the documentation locally using npm run dev
  • Links in the documentation are valid and working

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 17, 2026

Documentation Preview Ready

Your documentation preview has been successfully deployed!

Preview URL: https://d3ehv1nix5p99z.cloudfront.net/pr-cms-672/docs/user-guide/quickstart/overview/

Updated at: 2026-03-18T15:18:08.215Z

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: Request Changes

The code changes correctly update the TypeScript S3 location example to use the new location pattern with type: 's3', aligning it with the Python example. The tip text is also appropriately updated.

Issue Requiring Attention
  • PR Description Mismatch: The description mentions "Fixes malformed alert boxes in the 'Enabling Tracing' section of the traces page" and "session-management.mdx", but the actual changes update S3 location patterns in amazon-bedrock.mdx and amazon-bedrock.ts. Please update the PR description to accurately reflect the changes being made.

Once the PR description is updated to match the actual changes, this looks good to merge.

@github-actions
Copy link
Copy Markdown
Contributor

Assessment: Approve ✅

The PR description has been updated to accurately reflect the changes. The TypeScript S3 location example now correctly uses the location pattern with type: 's3', matching the Python example.

Changes verified:

  • ✅ TypeScript example updated to new pattern
  • ✅ Tip text updated to reference location
  • ✅ Consistent with Python example
  • ✅ PR description accurately describes changes

LGTM!

@zastrowm zastrowm merged commit e253860 into main Mar 18, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants