docs(bedrock): update S3 location examples to use new location pattern#672
docs(bedrock): update S3 location examples to use new location pattern#672
Conversation
Documentation Preview ReadyYour documentation preview has been successfully deployed! Preview URL: https://d3ehv1nix5p99z.cloudfront.net/pr-cms-672/docs/user-guide/quickstart/overview/ Updated at: 2026-03-18T15:18:08.215Z |
There was a problem hiding this comment.
Assessment: Request Changes
The code changes correctly update the TypeScript S3 location example to use the new location pattern with type: 's3', aligning it with the Python example. The tip text is also appropriately updated.
Issue Requiring Attention
- PR Description Mismatch: The description mentions "Fixes malformed alert boxes in the 'Enabling Tracing' section of the traces page" and "session-management.mdx", but the actual changes update S3 location patterns in
amazon-bedrock.mdxandamazon-bedrock.ts. Please update the PR description to accurately reflect the changes being made.
Once the PR description is updated to match the actual changes, this looks good to merge.
9897200 to
ef5d6ef
Compare
|
Assessment: Approve ✅ The PR description has been updated to accurately reflect the changes. The TypeScript S3 location example now correctly uses the Changes verified:
LGTM! |
Description
Update S3 location documentation to match latest typescript implementation.
Related Issues
N/A
Type of Change
Checklist
npm run devBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.