Skip to content

fix: improve redirects — preserve searchParams, subpath support, missing redirect targets#676

Merged
zastrowm merged 2 commits intostrands-agents:mainfrom
zastrowm:improve_redirects
Mar 18, 2026
Merged

fix: improve redirects — preserve searchParams, subpath support, missing redirect targets#676
zastrowm merged 2 commits intostrands-agents:mainfrom
zastrowm:improve_redirects

Conversation

@zastrowm
Copy link
Copy Markdown
Member

@zastrowm zastrowm commented Mar 18, 2026

Description

Fixes several redirect issues:

Related Issues

N/A

Type of Change

  • Bug fix

Checklist

  • I have read the CONTRIBUTING document
  • My changes follow the project's documentation style
  • I have tested the documentation locally using npm run dev
  • Links in the documentation are valid and working

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions
Copy link
Copy Markdown
Contributor

Documentation Preview Ready

Your documentation preview has been successfully deployed!

Preview URL: https://d3ehv1nix5p99z.cloudfront.net/pr-cms-676/docs/user-guide/quickstart/overview/

Updated at: 2026-03-18T14:39:56.481Z

@github-actions
Copy link
Copy Markdown
Contributor

Assessment: Approve

Clean bug fix that addresses three redirect issues effectively. The refactor from URL-based to path-based API in resolveRedirectFromUrl is a nice improvement that simplifies the code and better separates concerns.

Review Summary
  • Functionality: All redirect scenarios are handled correctly - searchParams preserved, subpath support added, missing redirect target fixed
  • Code Quality: Clean refactor with early returns for external URLs, proper TypeScript typing
  • Testing: Test coverage updated appropriately - all redirect tests pass
  • Documentation PR: Not required - this is an internal bug fix with no user-facing API changes

Well-structured fix! 👍

@zastrowm zastrowm merged commit 348b6fe into strands-agents:main Mar 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants