Skip to content

feat: claude citation support with BedrockModel #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

feat: claude citation support with BedrockModel #631

wants to merge 17 commits into from

Conversation

theagenticguy
Copy link
Collaborator

@theagenticguy theagenticguy commented Aug 7, 2025 •
edited
Loading

Description

Adds support for citations when using Anthropic Claude Sonnet 3.5v2 and above

Related Issues

#570

Documentation PR

Type of Change

New feature

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

  • I ran hatch run prepare

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@theagenticguy theagenticguy marked this pull request as ready for review August 8, 2025 21:49
@theagenticguy theagenticguy changed the title Claude citations feat: claude citation support with BedrockModel Aug 8, 2025
@zastrowm zastrowm added the area-provider Related to model providers label Aug 11, 2025
Unshure
Unshure reviewed Aug 11, 2025
View reviewed changes
@theagenticguy
fix: addresses comments
8bbd8b8 
* removes client exception handling
* moves citation into text elif
* puts relative imports back
@theagenticguy theagenticguy requested a review from Unshure August 18, 2025 22:41
Unshure
Unshure requested changes Aug 20, 2025
View reviewed changes
src/strands/models/bedrock.py

for citation in content["citationsContent"]["citations"]:
# Then emit citation metadata (for structure)
from ..types.streaming import CitationsDelta
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets be consistent and just import this at the top

@theagenticguy @Unshure
Update src/strands/models/bedrock.py
b9a5f1f 
Removes old comment

Co-authored-by: Nick Clegg <[email protected]>
@theagenticguy @Unshure
Update src/strands/models/bedrock.py
a4d825d 
Removes old comment

Co-authored-by: Nick Clegg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Unshure Unshure Unshure requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
area-provider Related to model providers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theagenticguy @Unshure @zastrowm