-
Notifications
You must be signed in to change notification settings - Fork 330
fix: Remove status field from toolResult for non-claude 3 models in Bedrock model provider #686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mehtarac
wants to merge
11
commits into
strands-agents:main
Choose a base branch
from
mehtarac:fix_status_field
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
208d081
fix: Remove status field from toolResult for non-claude 3 models in B…
mehtarac 5527376
fix: Remove status field from toolResult for non-claude 3 models in B…
mehtarac a19d4f8
fix: Remove status field from toolResult for non-claude 3 models in …
mehtarac f2489f4
fix: Remove status field from toolResult for non-claude 3 models in …
mehtarac 88ec214
fix: Remove status field from toolResult for non-claude 3 models in B…
mehtarac b0dda32
fix: Remove status field from toolResult for non-claude 3 models in B…
mehtarac a919bb6
fix: Remove status field from toolResult for non-claude 3 models in B…
mehtarac c314ad8
fix: Remove status field from toolResult for non-claude 3 models in B…
mehtarac 004eaa6
fix: Remove status field from toolResult for non-claude 3 models in B…
mehtarac d9d7c12
fix: Remove status field from toolResult for non-claude 3 models in B…
mehtarac 9139015
fix: Remove status field from toolResult for non-claude 3 models in B…
mehtarac File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehtarac marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to modify this? It seems like globally we always want ToolResult to contain status - and consumers may depend on status being present.
Can we just perform the filtering within the bedrock when we send the data to bedrock without propagating the issue throughout our code.
Meaning if from a tool I want to pass a ToolResult, we internally still require status to be provided
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I follow fully, but based on what I understand and experienced during testing -- there are some models available on bedrock that don't support the
status
field. In order to mitigate that, we do the filtering inbedrock.py
. The change here to the type was needed to pass the linter where thestatus
field is required in all cases. But since we have models that don't require status field, we don't require the status field. We DO return the status field for all models that accept thestatus
field.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @dbschmigelski here.
ToolResult
is the type that any result of a "StrandsTool" needs to return. If someone implements a custom tool, we want to require them to return thestatus
field as part of the tools execution. We can leave this code unchanged, and still filter out status when calling bedrock.