fix: fix stop reason for bedrock model when stop_reason #767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n tool use response.
zastrowm
requested changes
Aug 29, 2025
JackYPCOnline
had a problem deploying
to
auto-approve
GitHub Actions
Failure
JackYPCOnline
had a problem deploying
to
auto-approve
GitHub Actions
Failure
JackYPCOnline
had a problem deploying
to
auto-approve
GitHub Actions
Failure
zastrowm
approved these changes
Aug 29, 2025
Ratish1
pushed a commit
to Ratish1/sdk-python
that referenced
this pull request
Aug 30, 2025
…ts#767) * fix: fix stop reason for bedrock model when stop_reason is end_turn in tool use response. * change logger info to warning, optimize if condition * fix: add unit tests --------- Co-authored-by: Jack Yuan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix stop reason in bedrock model.
This issue is raised from side team, Bedrock returns stop_reason : "end_turn" in some tool use cases, which caused Strands SDK can't execute tool call in event loop. So we special case this for now, waiting for bedrock team fixing the issue.
Test with code in this link: #644
Description
Related Issues
Documentation PR
Type of Change
Bug fix
New feature
Breaking change
Documentation update
Other (please describe):
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.