feat(client.single): support plugin config argument #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nclsndr
commented
Oct 28, 2025
Comment on lines
+25
to
+30
| // Currently no well-known single-types with special API contracts | ||
| // Example structure if needed in the future: | ||
| // '[some-single-type]': { | ||
| // plugin: { name: '[plugin-name]', prefix: '[plugin-prefix]' }, | ||
| // wrapsData: false, | ||
| // }, |
Contributor
Author
There was a problem hiding this comment.
I couldn't come up with any use case here. Ideas?
Contributor
There was a problem hiding this comment.
There are none that I know of
Contributor
There was a problem hiding this comment.
Me either; pInging @Convly in case he's aware of any :)
jhoward1994
approved these changes
Oct 29, 2025
innerdvations
approved these changes
Oct 31, 2025
Comment on lines
+25
to
+30
| // Currently no well-known single-types with special API contracts | ||
| // Example structure if needed in the future: | ||
| // '[some-single-type]': { | ||
| // plugin: { name: '[plugin-name]', prefix: '[plugin-prefix]' }, | ||
| // wrapsData: false, | ||
| // }, |
Contributor
There was a problem hiding this comment.
Me either; pInging @Convly in case he's aware of any :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Add support for single-type based plugin based on pattern introduced in #98 and extended in #104
Why is it needed?
This feat is mostly to align
client.collectionandclient.singleAPIsHow to test it?
Unfortunately, no actual use cases are currently defined
Related issue(s)/PR(s)
Follows #98
Follows #104