fix: add string array to populate type #28
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
douwepausma
changed the title
|
Hi @douwepausma thanks for the PR - we'll take a look soon! 🚀 |
Convly
requested changes
Jan 22, 2025
Member
Convly
left a comment
Convly
left a comment
There was a problem hiding this comment.
Hey, the code LGTM but can you modify your commit so that it passes the commitlint check?
(the description shouldn't start with an uppercase letter)
jhoward1994
approved these changes
Jan 23, 2025
…ausma/sdk-js into add-string-array-to-populate-type
Contributor
Author
|
Sorry, I kinda messed up on this one, I'm quite new to contributing to projects 😅 As I don't really know how to fix this mess, I will close this request and open a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds string[] type to populate types.
Why is it needed?
String
arraysis already supported by the populate attributes, but the typings just didn't support it yet.How to test it?
Should build als usual, a missing type has been added to support already existing functionality.
Related issue(s)/PR(s)
#26