enhancement: rename the SDK constructor #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convly
added
pr: enhancement
Convly
force-pushed
the
enhancement/sdk-constructor
branch
from
bb886ad to
d8970fa
Compare
innerdvations
approved these changes
Jan 13, 2025
Contributor
innerdvations
left a comment
innerdvations
left a comment
There was a problem hiding this comment.
LGTM! It's a lot cleaner this way
Contributor
|
Very minor but I think this might need updating too? https://github.com/strapi/sdk-js/blob/d8970faa12490391e7b76b2873ce05b88441e727/src/sdk.ts#L325-L326 |
jhoward1994
approved these changes
Jan 20, 2025
Member
Author
Nice catch, updated! |
…ncement/sdk-constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Rename instances of
StrapiSDKbyStrapiandstrapiSDKbystrapi.Update in code, tests, documentation and comments.
Why is it needed?
Adopt a more conventional a developer-friendly naming for the SDK constructor.
How to test it?
The tests should work as usual, it's advised to manually test the built library with an example