-
Notifications
You must be signed in to change notification settings - Fork 14
feat(auth): refactor auth configuration logic #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
innerdvations
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but haven't tested it out
bc165c2 to
8fbcbbf
Compare
innerdvations
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even better now :)
I will try to test it tomorrow, not sure I have time today
Co-authored-by: Ben Irvin <[email protected]>
|
Looks good 👍🏻 I just can't get my head round how you would provide a different auth provider? Or even how auth providers would differ now if the auth property is just a string token? |
The idea was to simplify things while we only have one authentication method while keeping some space and flexibility in case we want to add something later. For instance if we end up having multiple providers people can use, we could introduce an Another option in the future that this solution allows, is to keep the auth to api token forever and delegate custom auth to extensions/plugins (interacting with an auth API to switch auth strategies) To summarize this abstract the current auth API to the minimum/simplest so that we have more option in the future and we don't limit ourselves with breaking changes |
What does it do?
Simplifies the auth configuration by flattening the properties.
Basically
becomes
Why is it needed?
Improve the developer experience when using the SDK
How to test it?
See example above, it should work the same for the undocumented
users-permissionprovider